Fix Crash when using Sha224 Callback with MAX32666#9712
Open
night1rider wants to merge 5 commits intowolfSSL:masterfrom
Open
Fix Crash when using Sha224 Callback with MAX32666#9712night1rider wants to merge 5 commits intowolfSSL:masterfrom
night1rider wants to merge 5 commits intowolfSSL:masterfrom
Conversation
Contributor
Author
|
Jenkins retest this please Jenkins disconnect from server during PRB-generic-config-parser |
Contributor
Author
|
Jenkins retest this please |
JacobBarthelmeh
requested changes
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Jenkins retest this please |
night1rider
force-pushed
the
max-32666-code-improvements
branch
from
de36166 to
ee3c785
Compare
Contributor
Author
|
Jenkins retest this please |
…k functions, fix sha224 crashing when using callbacks for MAX32666 due to unitialized struct.
…, also add HASH_KEEP to sha1 context with correct init/free calls
…nd copy/free crypto callbacks to replicate the non-callback code behavior when using MAX3266X_SHA_CB.
night1rider
force-pushed
the
max-32666-code-improvements
branch
from
f386691 to
daf3b06
Compare
Contributor
Author
|
rebased to pull in: #9829 |
dgarske
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that when using sha224 with callbacks on program/system would crash due to missing initialization.
Update MAX32666 to use Copy and Free Callbacks as well, with some general improvement to copy and free logic.
Crash bug is present in v5.8.4, but not previous stable v5.8.2. Was found when adding #9070 specifically commit 07b3695 which added callback for sha224.
Also found that when commit 9c1462a entered, there was no initialization for the callback structure and the MXC init call when the new wc_sha256_init_ex was added.